Fix planetary selection and moon orbit depth #350

Open

codex wants to merge 2 commits from fix/procgen-system-selection-refresh into dev_procgen

codex commented

2026-06-22 11:02:59 +02:00

Collaborator

Problems

Selecting a planet, moon, star or asteroid belt changed the Babylon renderer cache key, disposing and rebuilding the complete scene on every click.
Moon orbit guides used one depth plane, so they could not visually wrap around their parent planet.

Fix

Cache only the structural celestial system identity.
Manage the selection ring as an independent disposable overlay.
Update asteroid-belt selection intensity without rebuilding the scene.
Split each moon orbit into a rear arc behind the parent volume and a front arc above its disk.
Keep full rebuilds for actual system changes and canvas resize only.

Verification

npm run build:web passed after both commits.
Existing ivs-site-focus.component.scss budget warning remains unchanged.
git diff --check passed.

## Problems - Selecting a planet, moon, star or asteroid belt changed the Babylon renderer cache key, disposing and rebuilding the complete scene on every click. - Moon orbit guides used one depth plane, so they could not visually wrap around their parent planet. ## Fix - Cache only the structural celestial system identity. - Manage the selection ring as an independent disposable overlay. - Update asteroid-belt selection intensity without rebuilding the scene. - Split each moon orbit into a rear arc behind the parent volume and a front arc above its disk. - Keep full rebuilds for actual system changes and canvas resize only. ## Verification - `npm run build:web` passed after both commits. - Existing `ivs-site-focus.component.scss` budget warning remains unchanged. - `git diff --check` passed.

codex added 1 commit

2026-06-22 11:03:00 +02:00

Fix celestial selection scene rebuild 6f897689df

codex self-assigned this

2026-06-22 11:03:02 +02:00

codex requested review from ablandon

2026-06-22 11:03:03 +02:00

codex added 1 commit

2026-06-22 11:28:36 +02:00

Render moon orbits around parent planets db535c23c8

codex changed title from ~~Fix planetary system selection scene rebuild~~ to Fix planetary selection and moon orbit depth

2026-06-22 11:28:53 +02:00

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin fix/procgen-system-selection-refresh:fix/procgen-system-selection-refresh

git switch fix/procgen-system-selection-refresh

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev_procgen

git merge --no-ff fix/procgen-system-selection-refresh

git switch fix/procgen-system-selection-refresh

git rebase dev_procgen

git switch dev_procgen

git merge --ff-only fix/procgen-system-selection-refresh

git switch fix/procgen-system-selection-refresh

git rebase dev_procgen

git switch dev_procgen

git merge --no-ff fix/procgen-system-selection-refresh

git switch dev_procgen

git merge --squash fix/procgen-system-selection-refresh